Skip to content

feat: add implementation for number/int16/base/mul#10219

Draft
Lokeshranjan8 wants to merge 6 commits intostdlib-js:developfrom
Lokeshranjan8:int16-mul
Draft

feat: add implementation for number/int16/base/mul#10219
Lokeshranjan8 wants to merge 6 commits intostdlib-js:developfrom
Lokeshranjan8:int16-mul

Conversation

@Lokeshranjan8
Copy link
Copy Markdown
Contributor

@Lokeshranjan8 Lokeshranjan8 commented Feb 11, 2026 •
edited
Loading

Resolves #none .

Description

What is the purpose of this pull request?

This pull request:

  • {{TODO: add description describing what this pull request does}}

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

  • #{{TODO: add related issue number}}

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

I used ChatGPT to help with the signed 16-bit rounding logic

{{TODO: add disclosure if applicable}}

@stdlib-js/reviewers

@Lokeshranjan8
feat: add number/int16/base/mul
568285f 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: passed
  - task: lint_repl_help
    status: passed
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: passed
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: passed
  - task: lint_license_headers
    status: passed
---
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Feb 11, 2026
@Lokeshranjan8 Lokeshranjan8 changed the title feat: add number/int16/base/mul feat: add implementation for number/int16/base/mul Feb 11, 2026
@Lokeshranjan8 Lokeshranjan8 marked this pull request as draft February 11, 2026 18:51
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Feb 11, 2026
@Lokeshranjan8
Copy link
Copy Markdown
Contributor Author

Lokeshranjan8 commented Feb 12, 2026

@kgryte could you please suggest some references or examples? I’m finding it a bit difficult to write the runner.c file.

@Lokeshranjan8
fix: updated return value to 16bits
525cf19 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@Lokeshranjan8
fix: updated data.json using runner.c file
cf5c0e6 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: passed
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@stdlib-bot
Copy link
Copy Markdown
Contributor

stdlib-bot commented Feb 12, 2026 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
number/int16/base/mul $\color{green}177/177$
$\color{green}+0.00%$ 		$\color{green}3/3$
$\color{green}+0.00%$ 		$\color{green}1/1$
$\color{green}+0.00%$ 		$\color{green}177/177$
$\color{green}+0.00%$

The above coverage report was generated for the changes in this PR.

Lokeshranjan8
Lokeshranjan8 commented Feb 12, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/number/int16/base/mul/lib/polyfill.js
mbits = ( ((ha*lb) + (la*hb))<<8 )>>>0; // asm type annotation; possible integer overflow

// The final `|0` converts from an "unsigned integer" (possible integer overflow during sum) to a signed integer:
return ( ( (lbits + mbits) & 0xFFFF ) ^ 0x8000 ) - 0x8000; // asm type annotation
Copy link
Copy Markdown
Contributor Author

@Lokeshranjan8 Lokeshranjan8 Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this look like the right approach for rounding back to a signed int16 value ? Or is there a preferred pattern used in stdlib

@Lokeshranjan8
docs: add README.md file
2dc5a27 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@Lokeshranjan8 Lokeshranjan8 marked this pull request as ready for review February 12, 2026 14:58
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Feb 12, 2026
Planeshifter
Planeshifter requested changes Feb 14, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't have a chance to look into implementation yet, but the PR currently references Math.mul, which does not exist. That should be rectified.

Thanks for the PR!

Comment thread lib/node_modules/@stdlib/number/int16/base/mul/lib/main.js Outdated
Comment thread lib/node_modules/@stdlib/number/int16/base/mul/test/test.js Outdated
Comment thread lib/node_modules/@stdlib/number/int16/base/mul/test/fixtures/c/runner.c Outdated
@Planeshifter Planeshifter added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Feb 14, 2026
@Lokeshranjan8
refactor: remove unused Math.mul builtin detection
571942a 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: passed
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
Neerajpathak07
Neerajpathak07 requested changes Mar 1, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@Neerajpathak07 Neerajpathak07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Lokeshranjan8 Correct me I am wrong but I believe you have referred int32/mul as a base-line for this implementation. I would recommend against it, reason being this package landed in 8 years ago since that period a lot has been updated and optimized in the library.

Comment thread lib/node_modules/@stdlib/number/int16/base/mul/lib/polyfill.js Outdated
Comment thread lib/node_modules/@stdlib/number/int16/base/mul/lib/polyfill.js Outdated
Comment thread lib/node_modules/@stdlib/number/int16/base/mul/examples/index.js Outdated
@Lokeshranjan8
Copy link
Copy Markdown
Contributor Author

Lokeshranjan8 commented Mar 1, 2026

@Neerajpathak07 thanks for suggestion

@Lokeshranjan8 Lokeshranjan8 marked this pull request as draft March 1, 2026 12:35
@Lokeshranjan8
fix: implement suggested changes
8e3ea40 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: passed
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Neerajpathak07 Neerajpathak07 Neerajpathak07 requested changes

@Planeshifter Planeshifter Planeshifter requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

Needs Changes Pull request which needs changes before being merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Lokeshranjan8 @stdlib-bot @Planeshifter @Neerajpathak07